[
https://issues.apache.org/jira/browse/HDFS-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977230#comment-14977230
]
Zhe Zhang commented on HDFS-9312:
---------------------------------
Thanks for the work Eddy. The patch LGTM overall.
The only issue I see is that we should have a better name for
{{injectReplicas}}: 1) it only injects 1 replica; 2) it took me a while to
realize it injects a _corrupt_ replica. Maybe something like
{{injectCorruptReplica}}?
+1 pending Jenkins and after addressing the above.
> Fix TestReplication to be FsDataset-agnostic.
> ---------------------------------------------
>
> Key: HDFS-9312
> URL: https://issues.apache.org/jira/browse/HDFS-9312
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.7.1
> Reporter: Lei (Eddy) Xu
> Assignee: Lei (Eddy) Xu
> Priority: Minor
> Attachments: HDFS-9312.00.patch
>
>
> {{TestReplication}} uses raw file system access to inject dummy replica
> files. It makes {{TestReplication}} not compatible to non-fs dataset
> implementation.
> We can fix it by using existing {{FsDatasetTestUtils}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
