[
https://issues.apache.org/jira/browse/HDFS-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981239#comment-14981239
]
Daniel Templeton commented on HDFS-9339:
----------------------------------------
1. The createKey method is a local method that wraps the KeyProvider method.
One of the things it does is return false if there's an exception.
2. It would be possible to abstract it out, but it would involve another
anonymous inner class to perform the operations. I'm not sure that's an
improvement. That's the way it's done in TestKMS, but I don't like it. :)
3. They aren't actually repeated. There are two different controlling ACLs, so
one tests one ACL, and the other tests the other.
> Extend full test of KMS ACLs
> ----------------------------
>
> Key: HDFS-9339
> URL: https://issues.apache.org/jira/browse/HDFS-9339
> Project: Hadoop HDFS
> Issue Type: Test
> Components: HDFS
> Affects Versions: 2.7.1
> Reporter: Daniel Templeton
> Assignee: Daniel Templeton
> Attachments: HDFS-9339.001.patch
>
>
> HDFS-9295 adds an end-to-end test for KMS, but it is missing a dimension.
> The tests added in that JIRA hold the configuration constant and test that
> all operations succeed or fail as expected. More tests are needed that hold
> the operation constant and test that all possible configurations cause the
> operations to succeed or fail as expected. This JIRA is to add those tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
