[
https://issues.apache.org/jira/browse/HDFS-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14982092#comment-14982092
]
Rakesh R commented on HDFS-8777:
--------------------------------
Thanks a lot [~zhz] for the useful comments.
- 1, 2, 3 >> Agreed and will update it when creating another patch.
- 4 >> yeah, I think it is possible to add strict validation by checking
{{iip.getLastINode() == null}} and throw exception. Probably will keep the
condition [here
FSDirErasureCodingOp.java#L229|https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirErasureCodingOp.java#L229].
How about raise a minor sub-task under HDFS-8031 and discuss there separately?
- 5 >> To test erasure coding policy + snapshot behavior I think we need to add
extra code and do assertions in between. IMHO would be good to keep ec policy
tests separately. Does it make sense to you?
> Erasure Coding: add tests for taking snapshots on EC files
> ----------------------------------------------------------
>
> Key: HDFS-8777
> URL: https://issues.apache.org/jira/browse/HDFS-8777
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: erasure-coding
> Reporter: Jing Zhao
> Assignee: Rakesh R
> Labels: test
> Attachments: HDFS-8777-01.patch, HDFS-8777-02.patch,
> HDFS-8777-HDFS-7285-00.patch, HDFS-8777-HDFS-7285-01.patch
>
>
> We need to add more tests for (EC + snapshots). The tests need to verify the
> fsimage saving/loading is correct.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
