[ https://issues.apache.org/jira/browse/HDFS-9320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14982719#comment-14982719 ]
Hadoop QA commented on HDFS-9320: --------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 9s {color} | {color:blue} docker + precommit patch detected. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s {color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 0s {color} | {color:green} HDFS-8707 passed {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 12s {color} | {color:red} hadoop-hdfs-native-client in HDFS-8707 failed with JDK v1.8.0_60. {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 12s {color} | {color:red} hadoop-hdfs-native-client in HDFS-8707 failed with JDK v1.7.0_79. {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 17s {color} | {color:green} HDFS-8707 passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 14s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 10s {color} | {color:red} hadoop-hdfs-native-client in the patch failed with JDK v1.8.0_60. {color} | | {color:red}-1{color} | {color:red} cc {color} | {color:red} 0m 10s {color} | {color:red} hadoop-hdfs-native-client in the patch failed with JDK v1.8.0_60. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 10s {color} | {color:red} hadoop-hdfs-native-client in the patch failed with JDK v1.8.0_60. {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 12s {color} | {color:red} hadoop-hdfs-native-client in the patch failed with JDK v1.7.0_79. {color} | | {color:red}-1{color} | {color:red} cc {color} | {color:red} 0m 12s {color} | {color:red} hadoop-hdfs-native-client in the patch failed with JDK v1.7.0_79. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 12s {color} | {color:red} hadoop-hdfs-native-client in the patch failed with JDK v1.7.0_79. {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 12s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} Patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 11s {color} | {color:red} hadoop-hdfs-native-client in the patch failed with JDK v1.8.0_60. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 12s {color} | {color:red} hadoop-hdfs-native-client in the patch failed with JDK v1.7.0_79. {color} | | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 21s {color} | {color:red} Patch generated 425 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 14m 4s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-30 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12769791/HDFS-9320.HDFS-8707.000.patch | | JIRA Issue | HDFS-9320 | | Optional Tests | asflicense cc unit javac compile | | uname | Linux ef48dc4f6ab7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/patchprocess/apache-yetus-e77b1ce/precommit/personality/hadoop.sh | | git revision | HDFS-8707 / 85232c6 | | Default Java | 1.7.0_79 | | Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 | | compile | https://builds.apache.org/job/PreCommit-HDFS-Build/13300/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client-jdk1.8.0_60.txt | | compile | https://builds.apache.org/job/PreCommit-HDFS-Build/13300/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client-jdk1.7.0_79.txt | | compile | https://builds.apache.org/job/PreCommit-HDFS-Build/13300/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client-jdk1.8.0_60.txt | | cc | https://builds.apache.org/job/PreCommit-HDFS-Build/13300/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client-jdk1.8.0_60.txt | | javac | https://builds.apache.org/job/PreCommit-HDFS-Build/13300/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client-jdk1.8.0_60.txt | | compile | https://builds.apache.org/job/PreCommit-HDFS-Build/13300/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client-jdk1.7.0_79.txt | | cc | https://builds.apache.org/job/PreCommit-HDFS-Build/13300/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client-jdk1.7.0_79.txt | | javac | https://builds.apache.org/job/PreCommit-HDFS-Build/13300/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client-jdk1.7.0_79.txt | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/13300/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-native-client-jdk1.8.0_60.txt | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/13300/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-native-client-jdk1.7.0_79.txt | | JDK v1.7.0_79 Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/13300/testReport/ | | asflicense | https://builds.apache.org/job/PreCommit-HDFS-Build/13300/artifact/patchprocess/patch-asflicense-problems.txt | | modules | C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client | | Max memory used | 230MB | | Powered by | Apache Yetus http://yetus.apache.org | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/13300/console | This message was automatically generated. > libhdfspp should not use sizeof for stream parsing > -------------------------------------------------- > > Key: HDFS-9320 > URL: https://issues.apache.org/jira/browse/HDFS-9320 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client > Reporter: Bob Hansen > Assignee: James Clampffer > Attachments: HDFS-9320.HDFS-8707.000.patch > > > In a few places, we're using sizeof(int) and sizeof(short) to determine where > in the received buffers we should be looking for data. Those values are > compiler- and platform-dependent. We should use specified sizes, or at least > sizeof(int32_t). -- This message was sent by Atlassian JIRA (v6.3.4#6332)