[
https://issues.apache.org/jira/browse/HDFS-9242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brahma Reddy Battula updated HDFS-9242:
---------------------------------------
Attachment: HDFS-9242-002.patch
thanks [~ozawa] and [~wheat9] thanks for taking a look into this issue.
After take into deeper look, I think
1. Cant use volatile because it skips compiler optimizations
2. Cant make it static block, because it needs conf
So extracted to static method init(conf) and calling from DatanodeHttpServer
during startup. Hence multithread case will not occur for this.
Uploaded the patch...Kindly review the same..
> Fix Findbugs warning from webhdfs.DataNodeUGIProvider.ugiCache
> ---------------------------------------------------------------
>
> Key: HDFS-9242
> URL: https://issues.apache.org/jira/browse/HDFS-9242
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Xiaoyu Yao
> Assignee: Brahma Reddy Battula
> Priority: Critical
> Attachments: HDFS-9242-002.patch, HDFS-9242.patch
>
>
> This was introduced by HDFS-8855 and pre-patch warning can be found at
> https://builds.apache.org/job/PreCommit-HDFS-Build/12975/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html#DC_DOUBLECHECK
> {code}
> Code Warning
> DC Possible doublecheck on
> org.apache.hadoop.hdfs.server.datanode.web.webhdfs.DataNodeUGIProvider.ugiCache
> in new
> org.apache.hadoop.hdfs.server.datanode.web.webhdfs.DataNodeUGIProvider(ParameterParser,
> Configuration)
> Bug type DC_DOUBLECHECK (click for details)
> In class
> org.apache.hadoop.hdfs.server.datanode.web.webhdfs.DataNodeUGIProvider
> In method new
> org.apache.hadoop.hdfs.server.datanode.web.webhdfs.DataNodeUGIProvider(ParameterParser,
> Configuration)
> On field
> org.apache.hadoop.hdfs.server.datanode.web.webhdfs.DataNodeUGIProvider.ugiCache
> At DataNodeUGIProvider.java:[lines 49-51]
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
