[
https://issues.apache.org/jira/browse/HDFS-9007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986007#comment-14986007
]
Lei (Eddy) Xu commented on HDFS-9007:
-------------------------------------
Hi, [~mingma] . This patch looks great to me.
{code}
protected <T> DatanodeInfo getDatanodeInfo(T datanode) {
{code}
I feel like it'd better to use function overloading here. It'd be safer because
the compiler will handle the {{null}} case.
+1 once address the comment.
> Fix HDFS Balancer to honor upgrade domain policy
> ------------------------------------------------
>
> Key: HDFS-9007
> URL: https://issues.apache.org/jira/browse/HDFS-9007
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Ming Ma
> Assignee: Ming Ma
> Attachments: HDFS-9007.patch
>
>
> In the current design of HDFS Balancer, it doesn't use BlockPlacementPolicy
> used by namenode runtime. Instead, it has somewhat redundant code to make
> sure block allocation conforms with the rack policy.
> When namenode uses upgrade domain based policy, we need to make sure that
> HDFS balancer doesn't move blocks in a way that could violate upgrade domain
> block placement policy.
> In the longer term, we should consider how to make Balancer independent of
> the actual BlockPlacementPolicy as in HDFS-1431.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
