[ 
https://issues.apache.org/jira/browse/HDFS-9354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986041#comment-14986041
 ] 

Chris Nauroth commented on HDFS-9354:
-------------------------------------

Thanks, [~xyao].

Yes, you're right about {{ExpectedException}}.  On further review of the code, 
I don't think this part is really relevant to the current patch.  Please 
disregard this part of my feedback.  I'll review again when the change to use 
an {{@After}} cleanup method is available.

> Fix TestBalancer#testBalancerWithZeroThreadsForMove on Windows
> --------------------------------------------------------------
>
>                 Key: HDFS-9354
>                 URL: https://issues.apache.org/jira/browse/HDFS-9354
>             Project: Hadoop HDFS
>          Issue Type: Test
>            Reporter: Xiaoyu Yao
>            Assignee: Xiaoyu Yao
>         Attachments: HDFS-9354.00.patch
>
>
> This negative test expect HadoopIllegalArgumentException on illegal 
> configuration. It uses JUnit (expected=HadoopIllegalArgumentException.class)  
> and passed fine on Linux.
> On windows, this test passes as well. But it left open handles on NN metadata 
> directories used by MiniDFSCluster. As a result, quite a few of subsequent 
> TestBalancer unit tests can't start MiniDFSCluster. The open handles prevents 
> them from cleaning up NN metadata directories on Windows. 
> This JIRA is opened to explicitly catch the Exception and ensure the test 
> cluster is properly shutdown.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to