[ 
https://issues.apache.org/jira/browse/HDFS-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhe Zhang updated HDFS-9339:
----------------------------
       Resolution: Fixed
     Hadoop Flags: Reviewed
    Fix Version/s: 2.8.0
           Status: Resolved  (was: Patch Available)

Thanks Daniel for exploring this change. I agree that keeping the individual 
{{try-finally}} structures makes each subtest look cleaner. I was suggesting 
the consolidation to avoid duplicate code. So each option has its merits and 
I'm with you to use the current structure. +1 on the patch, I just committed to 
trunk and branch-2. Thanks for adding this thorough test!

> Extend full test of KMS ACLs
> ----------------------------
>
>                 Key: HDFS-9339
>                 URL: https://issues.apache.org/jira/browse/HDFS-9339
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: HDFS
>    Affects Versions: 2.7.1
>            Reporter: Daniel Templeton
>            Assignee: Daniel Templeton
>             Fix For: 2.8.0
>
>         Attachments: HDFS-9339.001.patch, HDFS-9339.002.patch
>
>
> HDFS-9295 adds an end-to-end test for KMS, but it is missing a dimension.  
> The tests added in that JIRA hold the configuration constant and test that 
> all operations succeed or fail as expected.  More tests are needed that hold 
> the operation constant and test that all possible configurations cause the 
> operations to succeed or fail as expected.  This JIRA is to add those tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to