[
https://issues.apache.org/jira/browse/HDFS-9354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiaoyu Yao updated HDFS-9354:
-----------------------------
Attachment: HDFS-9354.01.patch
Attach patch that uses @After to ensure cluster shutdown for JUnit based tests
in TestBalancer. Decide to keep try.. finally in the helper functions (such as
TestBalancer#doTest):
1. They could be indirectly called outside TestBalancer class (e.g.,
TestBlockTokenWithDFS#testEnd2End).
2. Non-JUnit based tests in TestBalancer#Main().
Both 1, 2 can not rely on @After to do cluster clean up.
> Fix TestBalancer#testBalancerWithZeroThreadsForMove on Windows
> --------------------------------------------------------------
>
> Key: HDFS-9354
> URL: https://issues.apache.org/jira/browse/HDFS-9354
> Project: Hadoop HDFS
> Issue Type: Test
> Reporter: Xiaoyu Yao
> Assignee: Xiaoyu Yao
> Attachments: HDFS-9354.00.patch, HDFS-9354.01.patch
>
>
> This negative test expect HadoopIllegalArgumentException on illegal
> configuration. It uses JUnit (expected=HadoopIllegalArgumentException.class)
> and passed fine on Linux.
> On windows, this test passes as well. But it left open handles on NN metadata
> directories used by MiniDFSCluster. As a result, quite a few of subsequent
> TestBalancer unit tests can't start MiniDFSCluster. The open handles prevents
> them from cleaning up NN metadata directories on Windows.
> This JIRA is opened to explicitly catch the Exception and ensure the test
> cluster is properly shutdown.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
