[ 
https://issues.apache.org/jira/browse/HDFS-8820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14992079#comment-14992079
 ] 

Ming Ma commented on HDFS-8820:
-------------------------------

Thanks [~arpitagarwal].

Regarding the {{RpcEngine}} backward compatibility, the interface is declared 
as {{@InterfaceStability.Evolving}}, so it seems ok to change. If not, do you 
think we can add the following method to the interface and have 
{{ProtobufRpcEngine}} to use the new method? The benefit is if we decide to add 
new field to RPC.Builder later, we don't need to modify the interface again.

{noformat}
  RPC.Server getServer(Class<?> protocol, RPC.Builder builder) throws 
IOException;
{noformat}

> Simplify enabling NameNode RPC congestion control and FairCallQueue
> -------------------------------------------------------------------
>
>                 Key: HDFS-8820
>                 URL: https://issues.apache.org/jira/browse/HDFS-8820
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>         Attachments: HDFS-8820.01.patch, HDFS-8820.02.patch, 
> HDFS-8820.03.patch
>
>
> Enabling RPC Congestion control and FairCallQueue settings can be simplified 
> with HDFS-specific configuration keys. Currently the configuration requires 
> knowing the exact RPC port number and also whether the service RPC port is 
> enabled or not separately. If a separate service RPC endpoint is not defined 
> then RPC congestion control must be enabled ([see 
> comment|https://issues.apache.org/jira/browse/HDFS-8820?focusedCommentId=14987848&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14987848]
>  from [~mingma] below.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to