[
https://issues.apache.org/jira/browse/HDFS-9401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996425#comment-14996425
]
Brahma Reddy Battula commented on HDFS-9401:
--------------------------------------------
{code}DatanodeID bpReg =datanode.getBPOfferService(bpid).bpRegistration;{code}
reference is DataNodeId, but it is instance of Datanoderegistration . so since
Datanoderegisration have equals() overridden.
wrapping bpReg with a new DatanodeID object.so we can compare 2
DatanodeIDs..Uploaded the patch for same ..kindly review..
> Fix the findbug in
> o.a.h.h.server.datanode.BlockRecoveryWorker$RecoveryTaskContiguous.recover()
> -----------------------------------------------------------------------------------------------
>
> Key: HDFS-9401
> URL: https://issues.apache.org/jira/browse/HDFS-9401
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Brahma Reddy Battula
> Attachments: HDFS-9401.patch
>
>
> Noticed following findbug in HDFS-9400
> {noformat}
> Call to
> org.apache.hadoop.hdfs.server.protocol.DatanodeRegistration.equals(org.apache.hadoop.hdfs.protocol.DatanodeInfo)
> in
> org.apache.hadoop.hdfs.server.datanode.BlockRecoveryWorker$RecoveryTaskContiguous.recover()
> Bug type EC_UNRELATED_TYPES (click for details)
> In class
> org.apache.hadoop.hdfs.server.datanode.BlockRecoveryWorker$RecoveryTaskContiguous
> In method
> org.apache.hadoop.hdfs.server.datanode.BlockRecoveryWorker$RecoveryTaskContiguous.recover()
> Actual type org.apache.hadoop.hdfs.protocol.DatanodeInfo
> Expected org.apache.hadoop.hdfs.server.protocol.DatanodeRegistration
> Value loaded from id
> Value loaded from bpReg
> org.apache.hadoop.hdfs.server.protocol.DatanodeRegistration.equals(Object)
> used to determine equality
> At BlockRecoveryWorker.java:[line 116]
> {noformat}
> https://builds.apache.org/job/PreCommit-HDFS-Build/13433/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
