[
https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14999674#comment-14999674
]
Kai Zheng commented on HDFS-8905:
---------------------------------
Thanks [~zhz] for the great comments! You understood the changes well and yes,
the main point of this refactoring is to unify all the relevant operations like
doRead, copyFrom and etc. into a *read* family methods, which may sound better
for *ReaderStrategy* to have. Sure I can add more javadocs for the methods to
make them more clear. Your concern is reasonable, how about moving
*ReaderStrategy* families (not trivial now) out of *DFSInputStream* to avoid
the naming conflict? Note there're no sharing variables between the two.
> Refactor DFSInputStream#ReaderStrategy
> --------------------------------------
>
> Key: HDFS-8905
> URL: https://issues.apache.org/jira/browse/HDFS-8905
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: erasure-coding
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Attachments: HDFS-8905-HDFS-7285-v1.patch, HDFS-8905-v2.patch
>
>
> DFSInputStream#ReaderStrategy family don't look very good. This refactors a
> little bit to make them make more sense.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
