[
https://issues.apache.org/jira/browse/HDFS-9408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15001169#comment-15001169
]
Haohui Mai commented on HDFS-9408:
----------------------------------
Looks good to me overall.
{code}
+
+set(EMPTY_FILE_CC ${CMAKE_CURRENT_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/empty.cc)
+file(WRITE ${EMPTY_FILE_CC} "")
{code}
Some comments on the hack will be useful.
{code}
+SET(HDFSPP_SUBLIBS bindings_c fs rpc reader proto common)
+IF(${CMAKE_SYSTEM_NAME} MATCHES "Linux")
+ SET(HDFSPP_SUBLIBS -Wl,--whole-archive ${HDFSPP_SUBLIBS}
-Wl,--no-whole-archive)
+ENDIF(${CMAKE_SYSTEM_NAME} MATCHES "Linux")
{code}
It makes sense to play around with the order of the {{HDFSPP_SUBLIBS}} to avoid
the linker flags hacks. It might make sense to substitute {{HDFSPP}} to
{{LIBHDFSPP}} in the files.
> extend the build system to produce static and dynamic libhdfspp libs
> --------------------------------------------------------------------
>
> Key: HDFS-9408
> URL: https://issues.apache.org/jira/browse/HDFS-9408
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Stephen
> Assignee: Stephen
> Fix For: HDFS-8707
>
> Attachments: HDFS-9408.HDFS-8707.001.patch,
> HDFS-9408.HDFS-8707.002.patch, HDFS-9408.HDFS-8707.003.patch,
> HDFS-9408.HDFS-8707.004.patch
>
>
> Generate static and dynamic libhdfspp libraries for use by other applications.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
