[ 
https://issues.apache.org/jira/browse/HDFS-9368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011974#comment-15011974
 ] 

Haohui Mai commented on HDFS-9368:
----------------------------------

{code}
+  Status Pread(void *buf, size_t *nbyte /* in/out */, off_t offset);
+  Status Read(void *buf, size_t *nbyte /* in/out */);
+  Status Seek(off_t *offset /* in/out */, std::ios_base::seekdir whence);
{code}

What about getting rid of the {{in/out}} annotation and putting some comments 
for each function? +1 after addressing it.

> Implement reads with implicit offset state in libhdfs++
> -------------------------------------------------------
>
>                 Key: HDFS-9368
>                 URL: https://issues.apache.org/jira/browse/HDFS-9368
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: James Clampffer
>            Assignee: James Clampffer
>         Attachments: HDFS-9368.HDFS-8707.000.patch, 
> HDFS-9368.HDFS-8707.001.patch, HDFS-9368.HDFS-8707.002.patch
>
>
> Currently only positional reads are supported.  Implement a stateful read 
> that keeps track of offset into file.  Also expose it in the c bindings as 
> hdfsRead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to