[ 
https://issues.apache.org/jira/browse/HDFS-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15012445#comment-15012445
 ] 

Zhe Zhang commented on HDFS-9342:
---------------------------------

I agree, we can add the test as part of HDFS-7661.

I will make another pass on the details of {{getAckedBlockGroupLength}} and 
post a review. Actually, this is a good use case for the improved testing in 
HDFS-9098. I will make {{getAckedBlockGroupLength}} visible for testing and 
create a test case in HDFS-9098. Would be great if you can help review.

> Erasure coding: client should update and commit block based on acknowledged 
> size
> --------------------------------------------------------------------------------
>
>                 Key: HDFS-9342
>                 URL: https://issues.apache.org/jira/browse/HDFS-9342
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: erasure-coding
>    Affects Versions: 3.0.0
>            Reporter: Zhe Zhang
>            Assignee: Walter Su
>         Attachments: HDFS-9342.01.patch
>
>
> For non-EC files, we have:
> {code}
> protected ExtendedBlock block; // its length is number of bytes acked
> {code}
> For EC files, the size of {{DFSStripedOutputStream#currentBlockGroup}} is 
> incremented in {{writeChunk}} without waiting for ack. And both 
> {{updatePipeline}} and {{commitBlock}} are based on size of 
> {{currentBlockGroup}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to