[ 
https://issues.apache.org/jira/browse/HDFS-9365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15015358#comment-15015358
 ] 

Rakesh R commented on HDFS-9365:
--------------------------------

Thanks [~szetszwo] for the patch. Few minor comments, apart from that it looks 
fine for me.

# {{DFSUtil#getInternalNameServiceIds}} - javadoc is missing. Also, it would be 
good to revisit the javadocs of other APIs which are using InternalNameServices.
# Incorrect format.
{code}
!ids.isEmpty()? ids:  DFSUtilClient.getNameServiceIds(conf);
{code}
# Please take a look at the checkstyle warnings related to the patch.

> Balaner does not work with the HDFS-6376 HA setup
> -------------------------------------------------
>
>                 Key: HDFS-9365
>                 URL: https://issues.apache.org/jira/browse/HDFS-9365
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: balancer & mover
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>         Attachments: h9365_20151119.patch
>
>
> HDFS-6376 added support for DistCp between two HA clusters.  After the 
> change, Balaner will use all the NN from both the local and the remote 
> clusters.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to