[ 
https://issues.apache.org/jira/browse/HDFS-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995704#comment-12995704
 ] 

Todd Lipcon commented on HDFS-1629:
-----------------------------------

This patch seems to have broken the MR contrib build:

    [javac] 
/data/1/scratch/patchqueue/patch-worker-32764/patch_62/svnrepo/src/contrib/raid/src/java/org/apache/hadoop/hdfs/server/namenode/BlockPlacementPolicyRaid.java:50:
 org.apache.hadoop.hdfs.server.namenode.BlockPlacementPolicyRaid is not 
abstract and does not override abstract method 
chooseTarget(java.lang.String,int,org.apache.hadoop.hdfs.server.namenode.DatanodeDescriptor,java.util.List<org.apache.hadoop.hdfs.server.namenode.DatanodeDescriptor>,boolean,java.util.HashMap<org.apache.hadoop.net.Node,org.apache.hadoop.net.Node>,long)
 in org.apache.hadoop.hdfs.server.namenode.BlockPlacementPolicy
    [javac] public class BlockPlacementPolicyRaid extends BlockPlacementPolicy {
    [javac]        ^

as well as a couple other errors there. Should we revert this until we have a 
fix ready for MR?

> Add a method to BlockPlacementPolicy for not removing the chosen nodes
> ----------------------------------------------------------------------
>
>                 Key: HDFS-1629
>                 URL: https://issues.apache.org/jira/browse/HDFS-1629
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.23.0
>
>         Attachments: h1629_20110216.patch, h1629_20110217.patch
>
>
> {{BlockPlacementPolicy}} supports chosen nodes in some of the 
> {{chooseTarget(..)}} methods.  The chosen nodes will be removed from the 
> output array.  For adding new datanodes to an existing pipeline, it is useful 
> to keep the chosen nodes in the output array.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to