[ 
https://issues.apache.org/jira/browse/HDFS-9263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025260#comment-15025260
 ] 

ASF GitHub Bot commented on HDFS-9263:
--------------------------------------

Github user cnauroth commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/53#discussion_r45787996
  
    --- Diff: 
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/GenericTestUtils.java
 ---
    @@ -59,6 +59,22 @@
     
       private static final AtomicInteger sequence = new AtomicInteger();
     
    +  /**
    +   * system property for test data: {@value}
    +   */
    +  public static final String SYSPROP_TEST_DATA_DIR = "test.build.data";
    +
    +  /**
    +   * Default path for test data: {@value}
    +   */
    +  public static final String DEFAULT_TEST_DATA_DIR =
    +      "target " + File.pathSeparator + "test" + File.pathSeparator + 
"data";
    --- End diff --
    
    I think you'll still need to incorporate the fixes I suggested earlier in a 
JIRA comment: remove the extra space character at the end of the `"target "` 
string literal, and switch from `File.pathSeparator` to `File.separator`.


> tests are using /test/build/data; breaking Jenkins
> --------------------------------------------------
>
>                 Key: HDFS-9263
>                 URL: https://issues.apache.org/jira/browse/HDFS-9263
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0
>         Environment: Jenkins
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Blocker
>         Attachments: HDFS-9263-001.patch, HDFS-9263-002.patch
>
>
> Some of the HDFS tests are using the path {{test/build/data}} to store files, 
> so leaking files which fail the new post-build RAT test checks on Jenkins 
> (and dirtying all development systems with paths which {{mvn clean}} will 
> miss.
> fix



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to