[
https://issues.apache.org/jira/browse/HDFS-9436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mingliang Liu updated HDFS-9436:
--------------------------------
Attachment: HDFS-9436.001.patch
Thanks for your review and comment.
No, the change was not intentional. Actually I should have been more careful
when I made the change. I was thinking the overall overhead to run the tests is
very small even if all ops have a larger default scale.
I don't think they all need this change. The v1 patch is to change the
{{BlockReportStats}} only.
While debugging the code, I've no idea how {{numOpsRequired}} is explained in
{{BlockReportStats}} (perhaps a bad design). When {{addBlock()}} adds blocks in
datanode, the {{TinyDatanode}} is not really updating the {{blocks}} list
(perhaps a bug). Moreover, the {{blockReportList}} is not built using the
{{blocks}} either, so the block report will be empty (I comment in
[HDFS-7435]). All the above makes the {{BlockReportStats}} dubious to me,
though this patch seems independent.
> Make NNThroughputBenchmark$BlockReportStats run with 10 datanodes by default
> ----------------------------------------------------------------------------
>
> Key: HDFS-9436
> URL: https://issues.apache.org/jira/browse/HDFS-9436
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: HDFS-9436.000.patch, HDFS-9436.001.patch
>
>
> This is a follow-up of [HDFS-9379].
> Though for actual benchmarking the defaults are rarely used, it would be good
> to change the default for {{numThreads}} as a >=10 value and may be
> {{numOpsRequired}} in {{BlockReportStats}} just to make sure the condition in
> [HDFS-9379] is tested in the future.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
