[ 
https://issues.apache.org/jira/browse/HDFS-9214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027919#comment-15027919
 ] 

Mingliang Liu commented on HDFS-9214:
-------------------------------------

Overall looks good. Minor comments:

# Any logging when re-configure properties in {{DataNode}} will be helpful
# Make {{DataXceiverServer#maxThreads}} final if possible
# Annotate {{getMaxThreads()}} with @VisiableForTesting

> Reconfigure DN concurrent move on the fly
> -----------------------------------------
>
>                 Key: HDFS-9214
>                 URL: https://issues.apache.org/jira/browse/HDFS-9214
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>    Affects Versions: 2.7.0
>            Reporter: Xiaobing Zhou
>            Assignee: Xiaobing Zhou
>         Attachments: HDFS-9214.001.patch, HDFS-9214.002.patch, 
> HDFS-9214.003.patch
>
>
> This is to reconfigure
> {code}
> dfs.datanode.balance.max.concurrent.moves
> {code} without restarting DN.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to