[ 
https://issues.apache.org/jira/browse/HDFS-9470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027935#comment-15027935
 ] 

Andrew Wang commented on HDFS-9470:
-----------------------------------

Hi Xiao, thanks for picking this up, overall looks good. Only a few comments:

* Is it possible to share some code between this new function and 
addToInodeMap? We could have a more generically named helper function, and call 
it from both addToInodeMap and loadRootInode. I don't think the log print is 
that important, can keep it generic.
* Little nit, we already have the XAttrFeature in loadRootINode, so we could 
pass it instead of looking it up again inside addRootDirToEncryptionZone.

> EncryptionZone on rootDir missing after NNrestart
> -------------------------------------------------
>
>                 Key: HDFS-9470
>                 URL: https://issues.apache.org/jira/browse/HDFS-9470
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>            Priority: Critical
>         Attachments: HDFS-9470.001.patch
>
>
> When restarting namenode, the encryption zone for {{rootDir}} is not loaded 
> correctly from fsimage



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to