[ 
https://issues.apache.org/jira/browse/HDFS-9228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032683#comment-15032683
 ] 

Bob Hansen commented on HDFS-9228:
----------------------------------

Land HDFS-9144 first; I'll have to rebase this and resolve the conflicts in the 
unit tests.

bq. -RetryPolicy should probably have a virtual destructor, or maybe a comment 
saying members can only be POD types. I'd prefer the virtual destructor 
approach.
Good catch.

-In rpc_connection.cc line 37 "NO_RETRY" should be "kNoRetry" to keep 
consistent with the naming conventions for constants.
You are correct, sir.

I will take care of both of those issues when I rebase the changes after 
HDFS-9144 lands.

> libhdfs++ should respect NN retry configuration settings
> --------------------------------------------------------
>
>                 Key: HDFS-9228
>                 URL: https://issues.apache.org/jira/browse/HDFS-9228
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Bob Hansen
>            Assignee: Bob Hansen
>         Attachments: HDFS-9228.HDFS-8707.001.patch, 
> HDFS-9228.HDFS-8707.002.patch, HDFS-9228.HDFS-8707.003.patch, 
> HDFS-9228.HDFS-8707.004.patch, HDFS-9228.HDFS-8707.005.patch, 
> HDFS-9228.HDFS-8707.006.patch
>
>
> Handle the use case of temporary network or NN hiccups and have a 
> configurable number of retries for NN operations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to