[
https://issues.apache.org/jira/browse/HDFS-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15042477#comment-15042477
]
Zhe Zhang commented on HDFS-9173:
---------------------------------
The patch looks pretty good. More detailed review will follow after a rebase.
bq. #2. about syncBlockFinalized, syncBlockUnfinalized.
Please see if the above makes sense to you -- separating {{syncBlockFinalized}}
and {{syncBlockUnfinalized}}. We can also do it as a follow-on.
A minor issue: better to use if-else to avoid constructing {{RecoveringBlock}}
unnecessarily
{code}
1403 rBlock = new RecoveringBlock(primaryBlock, recoveryInfos,
1404 uc.getBlockRecoveryId());
1405 if (b.isStriped()) {
1406 rBlock = new RecoveringStripedBlock(rBlock,
uc.getBlockIndices(),
1407 ((BlockInfoStriped) b).getErasureCodingPolicy());
1408 }
{code}
> Erasure Coding: Lease recovery for striped file
> -----------------------------------------------
>
> Key: HDFS-9173
> URL: https://issues.apache.org/jira/browse/HDFS-9173
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Walter Su
> Assignee: Walter Su
> Attachments: HDFS-9173.00.wip.patch, HDFS-9173.01.patch,
> HDFS-9173.02.step125.patch, HDFS-9173.03.patch, HDFS-9173.04.patch,
> HDFS-9173.05.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
