[
https://issues.apache.org/jira/browse/HDFS-9540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15053039#comment-15053039
]
Yongjun Zhang commented on HDFS-9540:
-------------------------------------
Thanks [~vinayrpet] and [~kihwal].
I created this jira really because I was worried there might be exceptions
other than StandbyException wrapped by RemoteException, and if they need to be
treated differently. My bad that I did not dig the code earlier. I looked at
the code a bit more, and don't see other exceptions except runtime ones.
I'm closing this jira. If someone add a new exception in the future in the code
flow that need to be handled differently than StandbyException w.r.t HDFS-7916,
we need to be aware of the handling here .
Thanks.
> Handle SafeModeException in ReportBadBlockAction#reportTo
> ---------------------------------------------------------
>
> Key: HDFS-9540
> URL: https://issues.apache.org/jira/browse/HDFS-9540
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Yongjun Zhang
> Assignee: Yongjun Zhang
>
> BPServiceActor#processQueueMessages() tries to execute the
> ReportBadBlockAction#reportTo(..) and on any exception, it will add back to
> queue.
> For StandbyExceptoin, this caused HDFS-7916, that a request kept being added
> back to the queue while it should not.
> HDFS-7916 solution treats all exceptions wrapped by RemoteException the same,
> including StandbyException. That is, when RemoteException is caught, the
> request is not added back to the queue.
> This solved the StandbyException issue reported in HDFS-7916, but the side
> effect is, it does not add the request back to the queue for
> SafeModeException wrapper by RemoteException, which appears to be incorrect.
> Thanks [~vinayrpet] and [~kihwal] for the discussion in HDFS-7916.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
