[
https://issues.apache.org/jira/browse/HDFS-9538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15053555#comment-15053555
]
James Clampffer commented on HDFS-9538:
---------------------------------------
Just a little early feedback based on a quick look. Once HDFS-9537 lands I can
give more detailed feedback; nothing major jumped out at me on this pass.
-It looks like ConfigurationLoader::SetSearchPath is breaking up the path into
subpaths of the full path. What's the intended use case for this?
-Should file_exists return false if the process doesn't have read permissions
for the file? I'd vote yes.
-Regarding the "Can we tell if it's a (transitive) symlink to a regular file?"
comment in file_exists. I think a symlink that resolves to a file that would
return true if used directly with file_exists should also return true. It
looks like it could be done by checking S_ISLNK(my_stat_struct.st_mode) +
realpath recursively with some reasonable depth limit to cover a few levels of
indirection.
> libhdfs++: load configuration from files
> ----------------------------------------
>
> Key: HDFS-9538
> URL: https://issues.apache.org/jira/browse/HDFS-9538
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Bob Hansen
> Assignee: Bob Hansen
> Attachments: HDFS-9538.HDFS-9537.000.patch
>
>
> One goal of the Configuration classes are to allow the consumers of the
> libhdfs++ library to deploy client applications into hadoop edge nodes and
> have them pick up the Hadoop configuration that has been deployed there.
> Note that we also need to support the use case where the consumer application
> will manage Hadoop configuration files itself, or will handle all
> configuration out-of-band.
> libhdfs++ should be able to read files that are found in the field and easily
> construct an instance that will communicate with the cluster.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
