[
https://issues.apache.org/jira/browse/HDFS-9557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15058610#comment-15058610
]
Chris Nauroth commented on HDFS-9557:
-------------------------------------
+1 for the idea, but I see an infinite recursion here:
{code}
public static ByteString getByteString(byte[] bytes) {
// return singleton to reduce object allocation
return (bytes.length == 0) ? ByteString.EMPTY : getByteString(bytes); //
<-- stack overflow for non-empty bytes
}
{code}
> Reduce object allocation in PB conversion
> -----------------------------------------
>
> Key: HDFS-9557
> URL: https://issues.apache.org/jira/browse/HDFS-9557
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs-client
> Affects Versions: 2.8.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HDFS-9557.patch
>
>
> PB conversions use {{ByteString.copyFrom}} to populate the builder.
> Unfortunately this creates unique instances for empty arrays instead of
> returning the singleton {{ByteString.EMPTY}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
