[ 
https://issues.apache.org/jira/browse/HDFS-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999487#comment-12999487
 ] 

Tanping Wang commented on HDFS-1653:
------------------------------------

     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
     [exec]                         Please justify why no new tests are needed 
for this patch.
     [exec]                         Also please list what manual steps were 
performed to verify this patch.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs 
warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
     [exec] 
     [exec]     +1 system tests framework.  The patch passed system tests 
framework compile.


Not tests added as current tests (pretty much all MiniDFSCluster based) need 
this change to send block received and is
tested as a part of many tests.


>  Block received is sent with invalid DatanodeRegistration 
> ----------------------------------------------------------
>
>                 Key: HDFS-1653
>                 URL: https://issues.apache.org/jira/browse/HDFS-1653
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: Federation Branch
>            Reporter: Tanping Wang
>            Assignee: Tanping Wang
>             Fix For: Federation Branch
>
>         Attachments: HDFS-1653.patch
>
>
> When sending block received bpRegistration should be used.  Also when 
> datanode shutsdown, if there are no namenode threads created, a null pointer 
> exception is thrown.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to