[ 
https://issues.apache.org/jira/browse/HDFS-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999606#comment-12999606
 ] 

Suresh Srinivas commented on HDFS-1645:
---------------------------------------

Forgot to include the test-patch results earlier:
     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
     [exec]                         Please justify why no new tests are needed 
for this patch.
     [exec]                         Also please list what manual steps were 
performed to verify this patch.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs 
warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
     [exec] 
     [exec]     +1 system tests framework.  The patch passed system tests 
framework compile.

Tests are not added because the existing datanode updgrade/finalize related 
tests test this change.


> DatanodeCommand Finalize sent from namenode to datanode must include block 
> pool ID 
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-1645
>                 URL: https://issues.apache.org/jira/browse/HDFS-1645
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: data-node, name-node
>    Affects Versions: Federation Branch
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>             Fix For: Federation Branch
>
>         Attachments: HDFS-1645.patch
>
>
> With federation, a namenode finalizes a block pool corresponding to it. 
> Finalize command requires block pool ID information. Datanode uses this to 
> finalize only the storage associated with the block pool.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to