[
https://issues.apache.org/jira/browse/HDFS-9325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15064652#comment-15064652
]
James Clampffer commented on HDFS-9325:
---------------------------------------
Thanks for build fix [~bobthansen]! Everything looks good now.
Would you mind giving a brief example of how this would be used in practice? I
get the gist of it from the patch but I'm not great with cmake so it's a little
hard to follow what all is going on and how I should validate that everything
is working correctly. I think this is something worth adding some good
documentation for since it targets users of the library; but that can be
deferred to another jira or one of the existing jiras for adding docs.
Here's my current understanding, let me know if I'm missing anything.
Part 1: gathering up dependencies
1) antrun now passes in a HADOOP_BUILD variable (seems like this is
unconditional?)
2) when HADOOP_BUILD is present copy all of the protobuf files and hdfs.h from
libhdfs into <project's target dir>/extern
Part 2: dumping libhdfs++ and dependencies elsewhere to be consumed by another
application, this is where I'm less certain
1) run the build as usual
2) if you go into the build output directory you can do a make install with a
DESTDIR variable set it can drop a tarball there
-Am I missing something about running cmake first? Is there something
analogous to passing DESTDIR into maven or antrun rather than having cmake
generate the makefiles first?
Also I'm a little unclear what exactly changed that makes libdl.so required.
Any thoughts here?
> Allow the location of hadoop source tree resources to be passed to CMake
> during a build.
> ----------------------------------------------------------------------------------------
>
> Key: HDFS-9325
> URL: https://issues.apache.org/jira/browse/HDFS-9325
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: James Clampffer
> Assignee: Bob Hansen
> Attachments: HDFS-9325.HDFS-8707.001.patch,
> HDFS-9325.HDFS-8707.002.patch, HDFS-9325.HDFS-8707.003.patch,
> HDFS-9325.HDFS-8707.004.patch, HDFS-9325.HDFS-8707.005.patch
>
>
> It would be nice if CMake could take an optional parameter with the location
> of hdfs.h that typically lives at libhdfs/includes/hdfs/hdfs.h, otherwise it
> would default to this location. This would be useful for projects using
> libhdfs++ that gather headers defining library APIs in a single location.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
