[
https://issues.apache.org/jira/browse/HDFS-9569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15065835#comment-15065835
]
Yongjun Zhang commented on HDFS-9569:
-------------------------------------
Hi [~cnauroth],
Thanks for reviewing and good comments!
Theoretically different fsimages could be corrupted different ways, so trying
all and print error for individual fsimage might be ok. Printing the same error
for each fsimage would not be a big problem IMO. But I agree that the reserved
path exception tend to be the same for all fsimages to be tried, and we can
keep the old control flow of throwing exception at the first fsimage tried.
I uploaded rev 3 with your suggestion of introducing
IllegalReservedPathException, which I think is a good idea.
Would you please take a look?
Thanks.
> Log the name of the fsimage being loaded for better supportability
> ------------------------------------------------------------------
>
> Key: HDFS-9569
> URL: https://issues.apache.org/jira/browse/HDFS-9569
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: Yongjun Zhang
> Assignee: Yongjun Zhang
> Priority: Trivial
> Labels: supportability
> Fix For: 2.7.3
>
> Attachments: HDFS-9569.001.patch, HDFS-9569.002.patch,
> HDFS-9569.003.patch
>
>
> When NN starts to load fsimage, it does
> {code}
> void loadFSImageFile(FSNamesystem target, MetaRecoveryContext recovery,
> FSImageFile imageFile, StartupOption startupOption) throws IOException {
> LOG.debug("Planning to load image :\n" + imageFile);
> ......
> long txId = loader.getLoadedImageTxId();
> LOG.info("Loaded image for txid " + txId + " from " + curFile);
> {code}
> A debug msg is issued at the beginning with the fsimage file name, then at
> the end an info msg is issued after loading.
> If the fsimage loading failed due to corrupted fsimage (see HDFS-9406), we
> don't see the first msg. It'd be helpful to always be able to see from NN
> logs what fsimage file it's loading.
> Two improvements:
> 1. Change the above debug to info
> 2. If exception happens when loading fsimage, be sure to report the fsimage
> name being loaded in the error message.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
