[ 
https://issues.apache.org/jira/browse/HDFS-9403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066001#comment-15066001
 ] 

GAO Rui commented on HDFS-9403:
-------------------------------

Hi [~zhz], I just found out that according to maven setting, currently we use 
Junit 4.11 in trunk branch. So, we could only create a org.junit.rules.Timeout 
instance by:
{code}
  @Rule
  public Timeout globalTimeout = new Timeout(60000);
{code}

But, to make the test code more human readable, we might prefer use 
{{Timeout.seconds(60)}}, but this is not supported until Junit 4.12( 
http://junit.org/apidocs/org/junit/rules/Timeout.html#seconds(long) ).

In this kind of situation, should we using {{new Timeout(60000)}} which has 
been marked as *Deprecated*, or we should try to shift the Junit version? 

> Erasure coding: some EC tests are missing timeout
> -------------------------------------------------
>
>                 Key: HDFS-9403
>                 URL: https://issues.apache.org/jira/browse/HDFS-9403
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: erasure-coding, test
>    Affects Versions: 3.0.0
>            Reporter: Zhe Zhang
>            Assignee: GAO Rui
>            Priority: Minor
>         Attachments: HDFS-9403-origin-trunk.00.patch, 
> HDFS-9403-origin-trunk.01.patch
>
>
> EC data writing pipeline is still being worked on, and bugs could introduce 
> program hang. We should add a timeout for all tests involving striped 
> writing. I see at least the following:
> * {{TestErasureCodingPolicies}}
> * {{TestFileStatusWithECPolicy}}
> * {{TestDFSStripedOutputStream}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to