[
https://issues.apache.org/jira/browse/HDFS-9593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069009#comment-15069009
]
Anu Engineer commented on HDFS-9593:
------------------------------------
Thanks you for the patch. I would have +1-ed it, but looking at the tests it
looks like we did not really run any tests in the Jenkins run.
So I am little hesitant to +1 this. Could you please add a test -- Something
every simple so that we know that this code is actually exercised somewhere.
Also it would be a good idea to assign this patch to yourself so that other
contributors know that you are working on it.
> BlockTokenIdentifier Code Review
> --------------------------------
>
> Key: HDFS-9593
> URL: https://issues.apache.org/jira/browse/HDFS-9593
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: BELUGA BEHR
> Priority: Trivial
> Attachments: BlockTokenIdentifier.HDFS-9593.patch
>
>
> Please find attached a code review of BlockTokenIdentifier.
> The only real change is using an explicit StringBuilder instead of an
> implicit one so that the internal buffer may be set more appropriately and
> checking for zero-length string instead of comparing to an empty string. The
> relatively small default buffer of 16 bytes would need to be expanded several
> times to fit the incoming string.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
