[
https://issues.apache.org/jira/browse/HDFS-9466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069915#comment-15069915
]
Xiao Chen commented on HDFS-9466:
---------------------------------
Thanks [~jojochuang] for working on this. The analysis sounds reasonable to me.
I have 1 question and 2 minor comments.
Question:
Do we know why this failed only for {{testDataXceiverCleansUpSlotsOnFailure}},
but not for similar checks in
{{testDataXceiverHandlesRequestShortCircuitShmFailure}} or
{{testPreReceiptVerificationDfsClientCanDoScr}}? I personally only saw
{{testDataXceiverCleansUpSlotsOnFailure}} fail intermittently, but never met
the others. I could've missed them, but just want to understand better.
Comments:
* Can we update {{testPreReceiptVerificationDfsClientCanDoScr}} to use the
extracted method {{checkNumberOfSegmentsAndSlots}}?
* Can we still set an estimated max for {{waitFor}}? The test case has its own
timeouts, but IMHO wait for {{Integer.MAX_VALUE}} is not best practice.
> TestShortCircuitCache#testDataXceiverCleansUpSlotsOnFailure is flaky
> --------------------------------------------------------------------
>
> Key: HDFS-9466
> URL: https://issues.apache.org/jira/browse/HDFS-9466
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: fs, hdfs-client
> Reporter: Wei-Chiu Chuang
> Assignee: Wei-Chiu Chuang
> Attachments: HDFS-9466.001.patch
>
>
> This test is flaky and fails quite frequently in trunk.
> Error Message
> expected:<1> but was:<2>
> Stacktrace
> {noformat}
> java.lang.AssertionError: expected:<1> but was:<2>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:555)
> at org.junit.Assert.assertEquals(Assert.java:542)
> at
> org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitCache$17.accept(TestShortCircuitCache.java:636)
> at
> org.apache.hadoop.hdfs.server.datanode.ShortCircuitRegistry.visit(ShortCircuitRegistry.java:395)
> at
> org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitCache.checkNumberOfSegmentsAndSlots(TestShortCircuitCache.java:631)
> at
> org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitCache.testDataXceiverCleansUpSlotsOnFailure(TestShortCircuitCache.java:684)
> {noformat}
> Thanks to [~xiaochen] for identifying the issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
