[
https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075832#comment-15075832
]
John Zhuge commented on HDFS-9522:
----------------------------------
Here is a short description for Patch 001:
* For different types of diff report entries, use subclass hierarchy
instead of C-style tagged union.
* Fix DiffReportEntry.hashcode to include field 'type' when
generating the hash code. (HDFS-9573)
* Add helper class DFSUtilClient.Bytes to convert String or byte[][]
to/from byte[].
* Add factory methods to create diff report entries.
* Add validateEntries and validateInverseEntries in SnapshotDiffReport to
assist unit testing.
* Rename field 'fullpath' to 'sourcePath' in SnapshotDiffReportEntryProto.
> Cleanup o.a.h.hdfs.protocol.SnapshotDiffReport
> ----------------------------------------------
>
> Key: HDFS-9522
> URL: https://issues.apache.org/jira/browse/HDFS-9522
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: John Zhuge
> Assignee: John Zhuge
> Priority: Minor
> Attachments: HDFS-9522-001.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The current DiffReportEntry is a C-style tagged union-like data structure.
> Recommend subclass hierarchy as in Java idiom.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
