[
https://issues.apache.org/jira/browse/HDFS-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999707#comment-12999707
]
Konstantin Boudnik commented on HDFS-1650:
------------------------------------------
bq. Apparently, this comment has also been addressed in the internal patch
review by Boris. and the feedback to this comment by Suresh was
When someone be looking into the test's code in say a month from now it is
highly unlikely that this thread - not to mention internal review of some kind
- will be available to that person.
Tests are generally perceived as examples and should be as self-explanatory as
possible. I am not trying to be a pain in the neck but test HAVE to be
considered as first-class citizen by dev. community setting an example to
people who are coming in to contribute their time/work into Hadoop. It might be
hard for noobs to read and understand some logic written in a JIRA or something.
> HDFS Federation : fix unit test case, TestReplication
> -----------------------------------------------------
>
> Key: HDFS-1650
> URL: https://issues.apache.org/jira/browse/HDFS-1650
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: Federation Branch
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Priority: Minor
> Fix For: Federation Branch
>
> Attachments: HDFS1650.patch
>
>
> HDFS Federation:
> TestReplication fails due to null pointer exception. When corrupting/deleting
> blocks in TestReplication#testPendingReplicationRetry() the loop should run
> for 3 datanodes.
> Instead it runs 6 times, resulting in null blockFile returned. Changing the
> loop to run 3 times.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
