[ 
https://issues.apache.org/jira/browse/HDFS-9601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15080778#comment-15080778
 ] 

Masatake Iwasaki commented on HDFS-9601:
----------------------------------------

Thanks for the comment, [~liuml07].

As you say, we can not reuse {{DFSOutputStream#addBlock}} depending on real dfs 
client as is. I think it is not problem to retry {{addBlock}} by itself because 
{{generateInputs}} is called in preparetion phase of the benchmark. It does not 
need to have same behavior with {{DFSOutputStream}}. It should not need even 
exponential backoff.

> NNThroughputBenchmark.BlockReportStats should handle 
> NotReplicatedYetException on adding block
> ----------------------------------------------------------------------------------------------
>
>                 Key: HDFS-9601
>                 URL: https://issues.apache.org/jira/browse/HDFS-9601
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Masatake Iwasaki
>            Assignee: Masatake Iwasaki
>         Attachments: HDFS-9601.001.patch
>
>
> TestNNThroughputBenchmark intermittently fails due to 
> NotReplicatedYetException. Because 
> {{NNThroughputBenchmark.BlockReportStats#generateInputs}} directly uses 
> {{ClientProtocol#addBlock}}, it must handles {{NotReplicatedYetException}} by 
> itself as {{DFSOutputStream#addBlock} do.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to