[ 
https://issues.apache.org/jira/browse/HDFS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000371#comment-13000371
 ] 

John George commented on HDFS-1189:
-----------------------------------

ant -Dforrest.home=${FORREST_HOME} -Djava5.home=${JAVA5} 
-Dfindbugs.home=${FINDBUGS_HOME} 
-Dpatch.file=/home/johngeo/hadoop_patches/HDFS-1189.patch test-patch


     [exec] BUILD SUCCESSFUL
     [exec] Total time: 32 seconds
     [exec] 
     [exec] 
     [exec] 
     [exec] 
     [exec] +1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 4 new or 
modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs 
(version 1.3.9) warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
     [exec] 
     [exec]     +1 system test framework.  The patch passed system test 
framework compile.
     [exec] 


> Quota counts missed between clear quota and set quota
> -----------------------------------------------------
>
>                 Key: HDFS-1189
>                 URL: https://issues.apache.org/jira/browse/HDFS-1189
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.20.2, 0.22.0
>            Reporter: Kang Xiao
>            Assignee: John George
>              Labels: hdfs, quota
>             Fix For: 0.22.0
>
>         Attachments: HDFS-1189.patch, HDFS-1189.patch, HDFS-1189.patch, 
> hdfs-1189-1.patch
>
>
> HDFS Quota counts will be missed between a clear quota operation and a set 
> quota.
> When setting quota for a dir, the INodeDirectory will be replaced by 
> INodeDirectoryWithQuota and dir.isQuotaSet() becomes true. When 
> INodeDirectoryWithQuota  is newly created, quota counting will be performed. 
> However, when clearing quota, the quota conf is set to -1 and 
> dir.isQuotaSet() becomes false while INodeDirectoryWithQuota will NOT be 
> replaced back to INodeDirectory.
> FSDirectory.updateCount just update the quota count for inodes that 
> isQuotaSet() is true. So after clear quota for a dir, its quota counts will 
> not be updated and it's reasonable. But when re seting quota for this dir, 
> quota counting will not be performed and some counts will be missed.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to