[
https://issues.apache.org/jira/browse/HDFS-9612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090851#comment-15090851
]
Zoran Dimitrijevic commented on HDFS-9612:
------------------------------------------
OK, so I read a bit more about this:
http://www.ibm.com/developerworks/library/j-jtp05236/
>From what I see, the only way to get InterruptedException is by some other
>thread sending it - so what you do here is correct (sorry for my C++ mind not
>really understanding what java expects causing this issue).
LGTM.
Only suggestion I might have is that logging change is not related to this fix,
which might make downporting this patch a bit harder. But, it is up to Hadoop
committers to make that decision. Sorry for not properly shutting down these
threads after they are not needed anymore.
> DistCp worker threads are not terminated after jobs are done.
> -------------------------------------------------------------
>
> Key: HDFS-9612
> URL: https://issues.apache.org/jira/browse/HDFS-9612
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: distcp
> Affects Versions: 2.8.0
> Reporter: Wei-Chiu Chuang
> Assignee: Wei-Chiu Chuang
> Attachments: HDFS-9612.001.patch, HDFS-9612.002.patch,
> HDFS-9612.003.patch, HDFS-9612.004.patch, HDFS-9612.005.patch,
> HDFS-9612.006.patch
>
>
> In HADOOP-11827, a producer-consumer style thread pool was introduced to
> parallelize the task of listing files/directories.
> We have a use case where a distcp job is run during the commit phase of a MR2
> job. However, it was found distcp does not terminate ProducerConsumer thread
> pools properly. Because threads are not terminated, those MR2 jobs never
> finish.
> In a more typical use case where distcp is run as a standalone job, those
> threads are terminated forcefully when the java process is terminated. So
> these leaked threads did not become a problem.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
