[
https://issues.apache.org/jira/browse/HDFS-9588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anu Engineer updated HDFS-9588:
-------------------------------
Attachment: HDFS-9588-HDFS-1312.003.patch
Hi [~arpitagarwal],
Thanks for the review. I have updated patch based on your comments.
bq.Missing check for presence of maxDiskBandwidth when deserializing the
protobuf message.
fixed.
bq. Instead of enumerating the error codes in
SubmitDiskBalancerPlanResponseProto can we just have the DataNode throw
appropriate exceptions, when the server-side implementation is done?
Added a new exception called diskbalancerException, will communicate all errors
using that.
bq. Missing Javadoc for ClientDatanodeProtocol#submitDiskBalancerPlan.
Fixed, will document Plan ID properly in the next patch, since that is the one
that really uses it.
bq. pick: Should DataNode#submitDiskBalancerPlan throw NotImplementedException
until it is implemented, instead of returning OK?
fixed
bq. Is the plan version used currently?
yes, it is left for future changes to plan json.
bq. Stylistic point - we can make most of the protobuf fields optional?
Fixed, converted some more fields to optional, left some as required since
without them the protocol would not make sense.
> DiskBalancer : Add submitDiskbalancer RPC
> -----------------------------------------
>
> Key: HDFS-9588
> URL: https://issues.apache.org/jira/browse/HDFS-9588
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: balancer & mover
> Affects Versions: HDFS-1312
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Attachments: HDFS-9588-HDFS-1312.001.patch,
> HDFS-9588-HDFS-1312.002.patch, HDFS-9588-HDFS-1312.003.patch
>
>
> Add a data node RPC that allows client to submit a diskbalancer plan to data
> node.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
