[
https://issues.apache.org/jira/browse/HDFS-9005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15093180#comment-15093180
]
Ming Ma commented on HDFS-9005:
-------------------------------
Thanks [~eddyxu] for the review!
Regarding the main question around JSON format, I like flat list of objects
better than grouping it by exclude attribute as that is just one of several
properties(although it is the most frequently changed property). Ease of
editing shouldn't be an issue as it is likely this file will be written by
high-level tool. Performance wise, reload time doesn't seem to have much
difference among different formats. When you said JSON array, do you mean
putting list of DN objects under a top-level element? BTW, the format used in
the patch is similar to rumen and yarn scheduler simulator job trace formats;
not that HDFS needs to be the same; just FYI. Otherwise, I am open to any
formats.
For {{HostsFileWriter#includeHosts/excludeHost}}, it does overwrite the whole
files. Maybe it should be renamed to initIncludeHosts/initExcludeHost. So far
the test code doesn't need addIncludeHosts/addExcludeHost.
After we agree on the actual JSON file format, I will update the patch with the
other suggestions you have.
> Provide support for upgrade domain script
> -----------------------------------------
>
> Key: HDFS-9005
> URL: https://issues.apache.org/jira/browse/HDFS-9005
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Ming Ma
> Assignee: Ming Ma
> Attachments: HDFS-9005.patch
>
>
> As part of the upgrade domain feature, we need to provide a mechanism to
> specify upgrade domain for each datanode. One way to accomplish that is to
> allow admins specify an upgrade domain script that takes DN ip or hostname as
> input and return the upgrade domain. Then namenode will use it at run time to
> set {{DatanodeInfo}}'s upgrade domain string. The configuration can be
> something like:
> {noformat}
> <property>
> <name>dfs.namenode.upgrade.domain.script.file.name</name>
> <value>/etc/hadoop/conf/upgrade-domain.sh</value>
> </property>
> {noformat}
> just like topology script,
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
