[
https://issues.apache.org/jira/browse/HDFS-9425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105072#comment-15105072
]
Vinayakumar B commented on HDFS-9425:
-------------------------------------
patch looks good.
Have some comments.
1. Need to consider blocks which are saved as part of lazy persist.
You can do this, in below way.
a. Add a mothod in {{FSVolumeImpl#incDfsUsedAndNumBlocks(..)}}.
b. Inside you can call, both {{FSVolumeImpl#incDfsUsed(..)}} and
{{BP#incrNumblocks()}}
c. Make sure {{FSVolumeImpl#incDfsUsedAndNumBlocks(..)}} is called instead
of {{FSVolumeImpl#incDfsUsed(..)}} in
{{FsDatasetImpl#onCompleteLazyPersist(..)}}
2. Nit: {{testDataNodeMXBeaNBlockCount()}}, Make the camel case correct.
> Expose number of blocks per volume as a metric
> ----------------------------------------------
>
> Key: HDFS-9425
> URL: https://issues.apache.org/jira/browse/HDFS-9425
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Brahma Reddy Battula
> Assignee: Brahma Reddy Battula
> Attachments: HDFS-9425.patch
>
>
> It will be helpful for user to know the usage in number of blocks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
