[
https://issues.apache.org/jira/browse/HDFS-9654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15108168#comment-15108168
]
Vinayakumar B commented on HDFS-9654:
-------------------------------------
Thanks for the refactor [~szetszwo].
Changes looks quite good.
Nit:
{code}
+ final String name = "block pool " + blockpoolID + " at " + bpSd.getRoot();
+ doUgrade(name, bpSd, nsInfo, bpPrevDir, bpTmpDir, bpCurDir, oldLV, conf);
+ }
+
+ private void doUgrade(String name, final StorageDirectory bpSd,
+ NamespaceInfo nsInfo, final File bpPrevDir, final File bpTmpDir,
+ final File bpCurDir, final int oldLV, Configuration conf)
+ throws IOException {
{code}
In the above code change, Nit: {{doUgrade}}.
Even, is this extraction to a method required, since its not used anywhere
else.? In both BPSS and DataStorage
> Code refactoring for HDFS-8578
> ------------------------------
>
> Key: HDFS-9654
> URL: https://issues.apache.org/jira/browse/HDFS-9654
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Priority: Minor
> Attachments: h9654_20160116.patch
>
>
> This is a code refactoring JIRA in order to change Datanode to process all
> storage/data dirs in parallel; see also HDFS-8578.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
