[
https://issues.apache.org/jira/browse/HDFS-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15110033#comment-15110033
]
Akira AJISAKA commented on HDFS-9618:
-------------------------------------
Mostly looks good to me. Would you join the following two if statements
together? I'm +1 if that is addressed.
{code}
if (blockLog.isDebugEnabled()) {
// log which blocks have been scheduled for replication
(snip)
blockLog.debug("BLOCK* ask {} to replicate {} to {}",
rw.getSrcNodes(),
rw.getBlock(), targetList);
}
if (blockLog.isDebugEnabled()) {
blockLog.debug("BLOCK* neededReplications = {} pendingReplications = {}",
neededReplications.size(), pendingReplications.size());
}
{code}
> Fix mismatch between log level and guard in
> BlockManager#computeRecoveryWorkForBlocks
> -------------------------------------------------------------------------------------
>
> Key: HDFS-9618
> URL: https://issues.apache.org/jira/browse/HDFS-9618
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 2.8.0
> Reporter: Masatake Iwasaki
> Assignee: Masatake Iwasaki
> Priority: Minor
> Attachments: HDFS-9618.001.patch
>
>
> Debug log message is constructed when {{Logger#isInfoEnabled}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
