[
https://issues.apache.org/jira/browse/HDFS-9643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15110973#comment-15110973
]
James Clampffer commented on HDFS-9643:
---------------------------------------
"you need to trim the readers_ member once you're done with remove_if.
remove_if only shuffles the live elements forward"
Good catch, I didn't expect it to work like that.
"What does the comment "no-op to keep method PV qualified in parent" mean?"
I was mixed up with cv-qualified being a real acronym; for some reason I
thought pv was too when I wrote that. I wanted the parent's method to be
declared pure virtual but that meant I had put stubs in the testing classes.
"I don't see an implementation of DataNodeConnection::Cancel(). Did I miss
something?"
It looked like the convention in datanodeconnection.h was to leave really tiny
methods in the header so I just left it there. I can move it out to the
implementation if you prefer.
> libhdfs++: Support async cancellation of read operations
> --------------------------------------------------------
>
> Key: HDFS-9643
> URL: https://issues.apache.org/jira/browse/HDFS-9643
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: James Clampffer
> Assignee: James Clampffer
> Attachments: HDFS-9643.HDFS-8707.000.patch,
> HDFS-9643.HDFS-8707.001.patch, HDFS-9643.HDFS-8707.002.patch
>
>
> It should be possible for any thread to cancel operations in progress on a
> FileHandle. Any ephemeral objects created by the FileHandle should free
> resources as quickly as possible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
