[
https://issues.apache.org/jira/browse/HDFS-9573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112720#comment-15112720
]
Hadoop QA commented on HDFS-9573:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s {color}
| {color:red} HDFS-9573 does not apply to trunk. Rebase required? Wrong Branch?
See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12781844/HDFS-9573-001.patch |
| JIRA Issue | HDFS-9573 |
| Powered by | Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/14207/console |
This message was automatically generated.
> SnapshotDiffReport$DiffReportEntry$hashCode should use type field
> -----------------------------------------------------------------
>
> Key: HDFS-9573
> URL: https://issues.apache.org/jira/browse/HDFS-9573
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: John Zhuge
> Assignee: John Zhuge
> Priority: Minor
> Attachments: HDFS-9573-001.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> DiffReportEntry.equals() uses field "type", but DiffReportEntry.hashCode()
> doesn't. This breaks the rules on equals and hashCode:
> * if a class overrides equals, it must override hashCode
> * when they are both overridden, equals and hashCode must use the same set of
> fields
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
