[
https://issues.apache.org/jira/browse/HDFS-9541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113302#comment-15113302
]
Zhe Zhang commented on HDFS-9541:
---------------------------------
Thanks Colin. I think having a builder method is a good idea. Patch LGTM
overall. A few minors:
# Should it be {{sizeof(struct hdfsStreamBuilder) + path_len}}? Since
{{bld->path}} already has 1 byte allocated to store the {{\0}}.
{code}
bld = malloc(sizeof(struct hdfsStreamBuilder) + path_len + 1);
{code}
# Should be s/hdfsStreamBuilderFree/hdfsStreamBuilderBuild/
{code}
* It is normally not necessary to call this function since
* hdfsStreamBuilderFree frees the builder.
{code}
# Might be worthwhile adding another {{hdfsOpenFile}} that actually uses
{{int64_t}} as {{defaultBlockSize}}?
> Add hdfsStreamBuilder API to libhdfs to support defaultBlockSizes greater
> than 2 GB
> -----------------------------------------------------------------------------------
>
> Key: HDFS-9541
> URL: https://issues.apache.org/jira/browse/HDFS-9541
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: libhdfs
> Affects Versions: 0.20.1
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-9541.001.patch
>
>
> We should have a new API in libhdfs which will support creating files with a
> default block size that is more than 31 bits in size. We should also make
> this a builder API so that it is easy to add more options later.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
