[ 
https://issues.apache.org/jira/browse/HDFS-9330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118377#comment-15118377
 ] 

Arpit Agarwal commented on HDFS-9330:
-------------------------------------

I think another pre-existing bug is this piece of code in 
{{DataNode#refreshVolumes}}:
{code}
      conf.set(DFS_DATANODE_DATA_DIR_KEY,
          Joiner.on(",").join(effectiveVolumes));
      dataDirs = getStorageLocations(conf);
{code}

If the effectiveVolumes set is not the same as the list passed in, this will be 
immediately undone as soon as {{DataNode#reconfigurePropertyImpl}} returns by 
{{ReconfigurableBase#reconfigureProperty}}
{code}
        reconfigurePropertyImpl(property, newVal);
        if (newVal != null) {
          getConf().set(property, newVal);
        } else {
          getConf().unset(property);
        }
{code}

I will comment on HDFS-7035.

> Support reconfiguring dfs.datanode.duplicate.replica.deletion without DN 
> restart 
> ---------------------------------------------------------------------------------
>
>                 Key: HDFS-9330
>                 URL: https://issues.apache.org/jira/browse/HDFS-9330
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>            Reporter: Xiaobing Zhou
>            Assignee: Xiaobing Zhou
>         Attachments: HDFS-9330-HDFS-9000.002.patch, 
> HDFS-9330-HDFS-9000.003.patch, HDFS-9330.001.patch
>
>
> This is to reconfigure
> {code}
> dfs.datanode.duplicate.replica.deletion
> {code}
> without restarting DN.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to