[
https://issues.apache.org/jira/browse/HDFS-7035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118406#comment-15118406
]
Arpit Agarwal edited comment on HDFS-7035 at 1/27/16 1:20 AM:
--------------------------------------------------------------
-There is probably one more bug. The behavior of {{ReconfigurableBase}} is not
consistent when calling {{reconfigurePropertyImpl}}.-
-{{ReconfigurationThread#run}} does not update the value in the cached
configuration object whereas {{ReconfigurableBase#reconfigureProperty}} does.
The contract of {{reconfigurePropertyImpl}} does not specify who is supposed to
update it.-
-You may want to hold off posting an updated patch for this and related Jiras
until we get this part answered.-
Ignore this, the comment was intended for HDFS-9330.
was (Author: arpitagarwal):
There is probably one more bug. The behavior of {{ReconfigurableBase}} is not
consistent when calling {{reconfigurePropertyImpl}}.
{{ReconfigurationThread#run}} does not update the value in the cached
configuration object whereas {{ReconfigurableBase#reconfigureProperty}} does.
The contract of {{reconfigurePropertyImpl}} does not specify who is supposed to
update it.
You may want to hold off posting an updated patch for this and related Jiras
until we get this part answered.
> Make adding a new data directory to the DataNode an atomic operation and
> improve error handling
> -----------------------------------------------------------------------------------------------
>
> Key: HDFS-7035
> URL: https://issues.apache.org/jira/browse/HDFS-7035
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode
> Affects Versions: 2.5.0
> Reporter: Lei (Eddy) Xu
> Assignee: Lei (Eddy) Xu
> Labels: 2.6.1-candidate
> Fix For: 2.7.0, 2.6.1
>
> Attachments: HDFS-7035.000.combo.patch, HDFS-7035.000.patch,
> HDFS-7035.001.combo.patch, HDFS-7035.001.patch, HDFS-7035.002.patch,
> HDFS-7035.003.patch, HDFS-7035.003.patch, HDFS-7035.004.patch,
> HDFS-7035.005.patch, HDFS-7035.007.patch, HDFS-7035.008.patch,
> HDFS-7035.009.patch, HDFS-7035.010.patch, HDFS-7035.010.patch,
> HDFS-7035.011.patch, HDFS-7035.012.patch, HDFS-7035.013.patch,
> HDFS-7035.014.patch, HDFS-7035.015.patch, HDFS-7035.016.patch
>
>
> It refactors {{DataStorage}} and {{BlockPoolSliceStorage}} to reduce the
> duplicate code and supports atomic adding volume operations. Also it
> parallels loading data volume operation: each thread loads one volume.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
