[
https://issues.apache.org/jira/browse/HDFS-9503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124403#comment-15124403
]
Konstantin Shvachko commented on HDFS-9503:
-------------------------------------------
# Mingliang, there is still some problem with diff generation for
{{TestNNThroughputBenchmark.java}}. I understand what you are trying to do, but
the diff looks wrong and is not applying for me.
# I do not think we need another parameter to switch to a remote NN. Whatever
comes from generic options or configuration should be treated as a NameNode
URI. If the URI is null or {{file:///}} we create a local NN, otherwise connect
to the remote. The main use case for NNThroughputBenchmark is a standalone
tool, but if people want they have many ways to connect it to a remote NN.
# Given the above you can still use URI to check if the NN is local or remote
instead of using {{fs instanceof DistributedFileSystem}}. The URI could be a
local variable in the {{run()}} method.
> Replace -namenode option with -fs for NNThroughputBenchmark
> -----------------------------------------------------------
>
> Key: HDFS-9503
> URL: https://issues.apache.org/jira/browse/HDFS-9503
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Reporter: Konstantin Shvachko
> Assignee: Mingliang Liu
> Attachments: HDFS-9053.000.patch, HDFS-9053.001.patch,
> HDFS-9053.002.patch, HDFS-9053.003.patch
>
>
> HDFS-7847 introduced a new option {{-namenode}}, which is intended to point
> the benchmark to a remote NameNode. It should use a standard generic option
> {{-fs}} instead, which is routinely used to specify NameNode URI in shell
> commands.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
