[
https://issues.apache.org/jira/browse/HDFS-9694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126174#comment-15126174
]
Kai Zheng commented on HDFS-9694:
---------------------------------
Wondering if to fix the following issues, they're there to be consistent with
existing codes. Guess better to fix them separately if needed.
{noformat}
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:118:
opRawBlockChecksum(in);: 'block' child have incorrect indentation level
8, expected level should be 6.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:119:
break;: 'block' child have incorrect indentation level 8, expected
level should be 6.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:303:
/** Receive OP_RAW_BLOCK_CHECKSUM */: First sentence should end with a period.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:304:
private void opRawBlockChecksum(DataInputStream in) throws IOException {:51:
'in' hides a field.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:305:
OpRawBlockChecksumProto proto =
OpRawBlockChecksumProto.parseFrom(vintPrefixed(in));: Line is longer than 80
characters (found 88).
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:313:
if (traceScope != null) traceScope.close();: 'if' construct must use
'{}'s.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:317:
/** Receive OP_STRIPED_BLOCK_CHECKSUM */: First sentence should end with a
period.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:318:
private void opStripedBlockChecksum(DataInputStream in) throws IOException
{:55: 'in' hides a field.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:332:
PBHelperClient.convert(proto.getHeader().getToken()),
proto.getMode());: Line is longer than 80 characters (found 81).
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java:334:
if (traceScope != null) traceScope.close();: 'if' construct must use
'{}'s.
{noformat}
> Make existing DFSClient#getFileChecksum() work for striped blocks
> -----------------------------------------------------------------
>
> Key: HDFS-9694
> URL: https://issues.apache.org/jira/browse/HDFS-9694
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Attachments: HDFS-9694-v1.patch
>
>
> This is a sub-task of HDFS-8430 and will get the existing API
> {{FileSystem#getFileChecksum(path)}} work for striped files. It will also
> refactor existing codes and layout basic work for subsequent tasks like
> support of the new API proposed there.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
